Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/socketcluster-server] missing some definitions #31969

Closed
ishantiw opened this issue Jan 8, 2019 · 4 comments
Closed

[@types/socketcluster-server] missing some definitions #31969

ishantiw opened this issue Jan 8, 2019 · 4 comments

Comments

@ishantiw
Copy link

ishantiw commented Jan 8, 2019

I want to use functions related to @types/socketcluster-server but some of them are missing its definition.

For example, I tried to use close()(scserver.js#L595) on SCServer but its definition is not present

import http from 'http';
import { attach, SCServer, SCServerSocket } from 'socketcluster-server';

const scServer =  attach(http.createServer());

scServer.close(() => { // Error: Property 'close' does not exist on type 'SCServer'
  // do something
  });

Similar to this, there are more definitions in SCServer which are missing are listed below.

getPath
generateId
removeMiddleware
verifyHandshake
verifyInboundEvent
isAuthTokenExpired
verifyOutboundEvent

Authors: @DanielRose

@DanielRose
Copy link
Contributor

Thanks! I'm busy tomorrow, but I'll take a look asap.

@ishantiw
Copy link
Author

ishantiw commented Jan 8, 2019

@DanielRose Thanks, appreciate your help 👍

@DanielRose
Copy link
Contributor

PR is in and accepted: #32136

@ishantiw
Copy link
Author

Thanks @DanielRose 👍

@ishantiw ishantiw changed the title [@types/socketcluster-server] missing some defintions [@types/socketcluster-server] missing some definitions Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants