Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/socketcluster-server] missing some definitions for SCServerSocket #32246

Closed
ishantiw opened this issue Jan 17, 2019 · 3 comments
Closed

Comments

@ishantiw
Copy link

I want to use functions related to @types/socketcluster-server but some of them are missing its definition. This is issue is similar to #31969 , thanks to @DanielRose on that.

For example, I tried to use destroy()(scserversocket.js#L595) on SCServerSocket but its definition is not present

import http from 'http';
import { attach, SCServerSocket } from 'socketcluster-server';

const scServer =  attach(http.createServer());
scServer.on('connection',
  (socket: SCServerSocket): void => {
     socket.destroy() // Destroy is not a function in socket (SCServerSocket)
  }

Similar to this, there are more definitions in SCServerSocket which are missing are listed below.

terminate
sendObjectBatch
encode
decode
sendObjectBatch
sendObject
deauthenticateSelf
triggerAuthenticationEvents

Authors: @DanielRose

@DanielRose
Copy link
Contributor

I'm very busy right now; I'll take a look next week.

@DanielRose
Copy link
Contributor

PR is in: #32589

@ishantiw
Copy link
Author

PR got merged, Thanks @DanielRose for your help 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants