-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@types/socketcluster update to v15 #41893
Comments
Ok, I'll take a look. |
socketcluster itself changed into a cli-tool with version 15, so there are no type definitions which make sense. However, I updated the other related type-definitions, ex. socketcluster-server and socketcluster-client: #42068 |
Thank you!!! |
PR was merged, so you can close this :) |
Ok I started using it and looking good, except for the 'subscribeStateChange' listener data (see docs: https://socketcluster.io/docs/api-ag-client-socket/#events) in socketcluster-client/lib/clientsocket.d.ts:414 the
I suppose I should create a new issue? Is there an easy way to amend your commit. Is another PR required? |
Yup, my mistake. The PR is merged, so a new PR is needed. Do you want to do that? |
Would you mind doing the PR? I think the merge gets fast tracked when an author of the package makes the PR and I've never done one for DefinitelyTyped before. Also, one other tiny thing came up: for socketcluster-server, I think the option 'protocolVersion' is not required, see socketcluster-server/server.d.ts:199-201 |
I made a new issue #42192 |
The PR moves into the same fast lane if the author approves it too, and he seems pretty responsive :) |
If you know how to fix the issue, make a pull request instead.
@types/socketcluster
package and had problems.Definitions by:
inindex.d.ts
) so they can respond.If you do not mention the authors the issue will be ignored.
Description
Socketcluster recently updated to v15. Code has been restructured based on
asyngular-client
andasyngular-server
and prefixSC
is nowAG
@DanielRose thank you for adding the SCxxx types but it would be great if you can update to v15 with AGxxxx.
The text was updated successfully, but these errors were encountered: