Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/stripe gets new version 50 times a day #49788

Closed
JonnyBurger opened this issue Nov 25, 2020 · 5 comments
Closed

@types/stripe gets new version 50 times a day #49788

JonnyBurger opened this issue Nov 25, 2020 · 5 comments

Comments

@JonnyBurger
Copy link
Contributor

@types/stripe has had 50 new releases in the past day. I wonder if this is a bug?

image

@orta
Copy link
Collaborator

orta commented Dec 3, 2020

/cc @sandersn

Hrm, so this is a deprecated types package ( https://www.npmjs.com/package/@types/stripe ) - maybe we're deploying every deprecated module on every publish cycle?

@sandersn
Copy link
Contributor

sandersn commented Dec 3, 2020

Looks like it started 10 days ago -- this was when it was deprecated, so I hope that this is a bug with only this package, and not with any deprecated package.

@sandersn
Copy link
Contributor

sandersn commented Dec 3, 2020

Yep, doesn't happen with @types/next-seo, which was deprecated a day later.

@sandersn
Copy link
Contributor

sandersn commented Dec 3, 2020

the logs make it look like a bug in the try-again logic for deprecation
when publishing the new version to be deprecated, it gave the following error each time:

publishing to github failed: Error: The expected resource was not found. : @types/stripe

BUT it stopped after a different deprecation also gave an error, but during the deprecation step instead of the publishing step:

Error: You can no longer unpublish this package.
Failed criteria: 
has dependent packages in the registry

Please deprecate it instead:

this makes no sense because deprecating a package from DT has two steps:

  1. publish a stub package with no types, just a README.
  2. deprecate the stub.

The stub-publish step doesn't check for the existence of the @types package. And the deprecate step doesn't try to unpublish.

@orta
Copy link
Collaborator

orta commented Jun 7, 2021

Hi thread, we're moving DefinitelyTyped to use GitHub Discussions for conversations the @types modules in DefinitelyTyped.

To help with the transition, we're closing all issues which haven't had activity in the last 6 months, which includes this issue. If you think closing this issue is a mistake, please pop into the TypeScript Community Discord and mention the issue in the definitely-typed channel.

@orta orta closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants