Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): v16 #53669

Merged
merged 5 commits into from
Jul 3, 2021
Merged

feat(node): v16 #53669

merged 5 commits into from
Jul 3, 2021

Conversation

SimonSchick
Copy link
Contributor

@SimonSchick SimonSchick commented Jun 7, 2021

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

🚨🚨 As usual, please ignore the contents of v15, the files are a copy from the previous root directory. 🚨🚨

Depends on #53566

Caveats:

  • perf_hooks details are not fully modelled, trying to figure out how to make it more type safe but is difficult.
  • Changelog is not very clear, might've missed something
  • cluster module requires esInterop flag to be set, this was done to dedupe the module definition and is probably acceptable given it's a major version change?

cc @connor4312 @npm1

Additional changes since this a major version:

  • Remove NodeJS.Global and fully rely on globalThis, this reduces overhead when new global are introduced and is generally redundant now.

  • Move Buffer definition into buffer module (this isn't breaking but is somewhat of a big change).

  • Move InspectOptions into util module.

  • Remove some deprecated/low usage NodeJS namespace scoped interfaces into their respective modules (domain, console) and move corresponding tests

  • Reduce usage of any in assertions and a couple other places to improve type safety.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 7, 2021

@SimonSchick Thank you for submitting this PR!

This is a live comment which I will keep updated.

8 packages in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect more than one package

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 53669,
  "author": "SimonSchick",
  "headCommitOid": "195467d34a90a34f10bec0584ce298c70a49a3d4",
  "lastPushDate": "2021-07-02T04:37:52.000Z",
  "lastActivityDate": "2021-07-03T00:04:33.000Z",
  "mergeOfferDate": "2021-07-02T05:19:42.000Z",
  "mergeRequestDate": "2021-07-03T00:04:33.000Z",
  "mergeRequestUser": "SimonSchick",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "amqp",
      "kind": "edit",
      "files": [
        {
          "path": "types/amqp/amqp-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "seikho",
        "jonnysparkplugs"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "cluster-hub",
      "kind": "edit",
      "files": [
        {
          "path": "types/cluster-hub/cluster-hub-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/cluster-hub/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "chunkai1312"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "fs-extra",
      "kind": "edit",
      "files": [
        {
          "path": "types/fs-extra/fs-extra-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alan-agius4",
        "midknight41",
        "shiftkey",
        "mees-",
        "jrockwood",
        "sangdth",
        "ffflorian",
        "peterblazejewicz",
        "NotWoods"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "jest-in-case",
      "kind": "edit",
      "files": [
        {
          "path": "types/jest-in-case/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "geovanisouza92"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "libpq",
      "kind": "edit",
      "files": [
        {
          "path": "types/libpq/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/libpq/libpq-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Lodin"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "node-resque",
      "kind": "edit",
      "files": [
        {
          "path": "types/node-resque/node-resque-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "gordey4doronin",
        "petetnt"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/assert/strict.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/async_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/console.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/diagnostic_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dns/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/domain.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/globals.global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/https.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/module.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/path.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/punycode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/querystring.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/readline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/repl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/scripts/generate-inspector/README.md",
          "kind": "markdown"
        },
        {
          "path": "types/node/scripts/generate-inspector/inspector.d.ts.template",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/node/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/stream/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/string_decoder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test/async_hooks.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/buffer.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/cluster.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/console.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/fs.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/module.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/perf_hooks.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/stream.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/timers.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/util.ts",
          "kind": "test"
        },
        {
          "path": "types/node/test/util_types.ts",
          "kind": "test"
        },
        {
          "path": "types/node/timers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/timers/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/trace_events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts3.6/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/ts3.6/node-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/node/tty.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/url.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/util/types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/assert/strict.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/async_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/buffer.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/console.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/constants.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/diagnostic_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/dns/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/domain.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/fs/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/globals.global.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/https.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/module.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/node-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/os.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/node/v15/path.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/punycode.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/querystring.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/readline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/repl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/stream/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/string_decoder.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/test/assert.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/async_hooks.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/buffer.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/child_process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/cluster.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/constants.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/crypto.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/dgram.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/diagnostic_channel.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/dns.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/events.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/fs.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/global.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/globals.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/http.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/http2.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/module.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/net.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/os.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/path.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/perf_hooks.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/querystring.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/readline.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/repl.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/stream.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/string_decoder.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/timers.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/timers_promises.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/tls.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/tty.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/url.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/util.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/util_types.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/v8.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/vm.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/wasi.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/worker_threads.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/test/zlib.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/timers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/timers/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/trace_events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/ts3.6/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/ts3.6/base.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/ts3.6/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/ts3.6/node-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v15/ts3.6/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`, `compilerOptions.lib.1`, `compilerOptions.target`)"
        },
        {
          "path": "types/node/v15/ts3.6/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        },
        {
          "path": "types/node/v15/tsconfig.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions.lib.0`, `compilerOptions.target`)"
        },
        {
          "path": "types/node/v15/tslint.json",
          "kind": "package-meta",
          "suspect": "not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-tslintjson) (check: `rules`)"
        },
        {
          "path": "types/node/v15/tty.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/url.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/util/types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/v8.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/vm.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/wasi.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/worker_threads.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v15/zlib.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v8.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/vm.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/wasi.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/worker_threads.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/zlib.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "DefinitelyTyped",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "KSXGitHub",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "n-e",
        "galkin",
        "parambirs",
        "eps1lon",
        "SimonSchick",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "nguymin4",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "Ryan-Willpower",
        "peterblazejewicz",
        "addaleax",
        "JasonHK",
        "victorperin",
        "ZYSzys"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "tile-reduce",
      "kind": "edit",
      "files": [
        {
          "path": "types/tile-reduce/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/tile-reduce/tile-reduce-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "DenisCarriere"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2021-07-02T05:19:07.000Z",
      "isMaintainer": true
    },
    {
      "type": "stale",
      "reviewer": "dnalborczyk",
      "date": "2021-07-01T21:12:22.000Z",
      "abbrOid": "d9b5705"
    }
  ],
  "mainBotCommentID": 856310911,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Author is Owner The author of this PR is a listed owner of the package. Check Config Changes a module config files labels Jun 7, 2021
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 7, 2021

@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Jun 7, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 7, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jun 7, 2021
@typescript-bot
Copy link
Contributor

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jun 7, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jun 7, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 7, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jun 7, 2021
@typescript-bot
Copy link
Contributor

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jun 7, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jun 7, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jun 7, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 7, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board Jun 7, 2021
@typescript-bot
Copy link
Contributor

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Edits multiple packages and removed Author is Owner The author of this PR is a listed owner of the package. The CI failed When GH Actions fails labels Jun 8, 2021
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jun 8, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board Jun 8, 2021
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in New Pull Request Status Board Jun 8, 2021
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jun 8, 2021
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jun 8, 2021
@typescript-bot
Copy link
Contributor

@SimonSchick The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Check Config Changes a module config files Critical package Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner Too Many Owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet