Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add d3-scale-chromatic definitions and tests. #11370

Merged
1 commit merged into from
Sep 21, 2016
Merged

Add d3-scale-chromatic definitions and tests. #11370

1 commit merged into from
Sep 21, 2016

Conversation

tomwanzek
Copy link
Contributor

This PR is related to issue #9936 it adds definitions and tests for d3-scale-chromatic provided thanks to @Ledragon .

Thanks in advance for merging it. I reviewed the definitions 👍

Add a new type definition.

  • checked compilation succeeds with --target es6 and --noImplicitAny options.
  • has correct naming convention
  • has a test file with the suffix of -tests.ts or -tests.tsx.

@dt-bot
Copy link
Member

dt-bot commented Sep 21, 2016

d3-scale-chromatic/index.d.ts

Checklist

@ghost ghost merged commit 4f60250 into DefinitelyTyped:types-2.0 Sep 21, 2016
@tomwanzek tomwanzek deleted the d3-scale-chromatic branch September 21, 2016 13:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants