Update to Electron 1.4.2 #11766
Merged
Update to Electron 1.4.2 #11766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
reviewed
Oct 6, 2016
| @@ -740,7 +751,7 @@ declare namespace Electron { | |||
| * The BrowserWindow class gives you ability to create a browser window. | |||
| * You can also create a window without chrome by using Frameless Window API. | |||
| */ | |||
| class BrowserWindow extends EventEmitter { | |||
| class BrowserWindow extends EventEmitter implements Destroyable { | |||
There was a problem hiding this comment.
Although it is not a modification in this PR, I think we can use NodeJS.EventEmitter. It was interface previously, but now it's a class and can be extended.
There was a problem hiding this comment.
updated to use NodeJS.EventEmitter
|
Nice work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case 2. Improvement to existing type definition.