Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also allow Raw for defaultTo #11855

Conversation

RWOverdijk
Copy link

.now() wasn't really cooperating. Now it is. >:)

.now() wasn't really cooperating. Now it is. >:)
@dt-bot
Copy link
Member

dt-bot commented Oct 8, 2016

knex/knex.d.ts

to author (@tkqubo). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@mhegazy
Copy link
Contributor

mhegazy commented Oct 8, 2016

@tkqubo can you review this change

@tkqubo
Copy link
Contributor

tkqubo commented Oct 9, 2016

Type Value seems to have a type candidate Knex.Raw already. Does this PR make any difference?

@RWOverdijk
Copy link
Author

That's so weird... I just saw that. My installation doesn't though. There's not even a declare module Knex. Am I using the wrong version? https://registry.npmjs.org/@types/knex/-/knex-0.0.32.tgz

@vvakame
Copy link
Member

vvakame commented Oct 10, 2016

@types package from types-2.0 branch now.
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/types-2.0/knex/index.d.ts

@RWOverdijk
Copy link
Author

@vvakame I suppose that has something to do with me not seeing the same thing? How can I get them?

@vvakame
Copy link
Member

vvakame commented Oct 12, 2016

Oh, sorry. I'm confusing you.
Now, npm info @types/knex returns version 0.0.35. It contains newest definitions. please check it.

@RWOverdijk
Copy link
Author

I see it now! Thanks a lot.

@RWOverdijk RWOverdijk closed this Oct 12, 2016
@RWOverdijk RWOverdijk deleted the hotfix/dominate-defaultValue-with-charm branch December 19, 2016 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants