Fabric: Fixed the return-type of the IIntersectionStatic constructor

[webbiesdk]

Having a constructor return "void" never makes sense, since a function called with "new" will always return something different from void.

Please fill in this template.

• Make your PR against the master branch.
• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run tsc without errors.
• Run npm run lint package-name if a tslint.json is present.

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes:
• Increase the version number in the header if appropriate.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "../tslint.json" }.

[dt-bot]

fabric/index.d.ts

to authors (@oklemencic @joewashear007 @mrand01). Could you review this PR?
👍 or 👎?

Checklist

• pass the Travis CI test?

[ghost]

A better solution would be to have class Intersection, ditch IIntersectionStatic, and add a constructor and static methods to Intersection.

[webbiesdk]

Yes it would (I did read that part of your FAQ), but i decided to change as little as possible, and just correct the error that i found, instead of doing a major refactorization.

Also, as long as this issue is open: microsoft/TypeScript#819, there can be a legitimate reason for using interfaces instead of class declaratons.

And I don't know enough about Fabric to determine why they are using interfaces instead of class declaration, and I don't want to break things.

So yes, it would perhaps be better, but no, I won't do it.

[ghost]

Done in #13833