Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

artyom.js - Created typescript definition file #13947

Merged
merged 6 commits into from
Jan 18, 2017

Conversation

semagarcia
Copy link
Contributor

Please fill in this template.

  • [ X ] Make your PR against the master branch.
  • [ X ] Use a meaningful title for the pull request. Include the name of the package modified.
  • [ X ] Test the change in your own code. (Compile and run.)
  • [ X ] Follow the advice from the readme.
  • [ X ] Avoid common mistakes.
  • [ X ] Run tsc without errors.
  • [ X ] Run npm run lint package-name if a tslint.json is present.

Select one of these and delete the others:

If adding a new definition:

  • [ X ] The package does not provide its own types, and you can not add them.
  • [ X ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [ X ] Create it with npm run new-package package-name, not by basing it on an existing project.
  • [ X ] tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

@dt-bot
Copy link
Member

dt-bot commented Jan 11, 2017

artyom.js/index.d.ts

Checklist

In local, the npm run lint said that this header is not allowed, but in travis seems to work
@mhegazy mhegazy merged commit 9001e6d into DefinitelyTyped:master Jan 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants