[lodash] change weakmap declaration to work with TS 2.2 #14502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lodash - change WeakMap declaration - fix DefinitelyTyped#14324
Revert "lodash - change WeakMap declaration - fix DefinitelyTyped#14324"
|
lodash/index.d.ts to authors (@bczengel @chrootsu @stepancar). Could you review this PR? Checklist
|
MartinSGill
added a commit
to MartinSGill/vscode-spell-checker
that referenced
this pull request
Feb 8, 2017
Typescript 2.2.0 is in RC and npm is alrady downloading it based on the previous dependency version rules. VSCode is currently using 2.1.5, so it seems to make sense to follow that version, additinally the 2.2 compiler has a breaking change with lodash that prevents building spellchecker if tsc 2.2 is used. cf. DefinitelyTyped/DefinitelyTyped#14502
|
Please, verify it %) |
|
What do you think about I'm just thinking about how custom |
|
|
|
I can't use lodash without this fix... |
|
Any ETA on getting this merged? |
10 tasks
|
This pull request is dirty since contains another junk commits. I've made another one in pull request #14662. I also follow @eschwartz suggestion to use |
dahlbyk
added a commit
to NewBoCo/DefinitelyTyped
that referenced
this pull request
Mar 7, 2017
Pinning to TS 2.1 due to: DefinitelyTyped#14502 Versions are otherwise aligned with Griddle 0.7.1: https://github.com/GriddleGriddle/Griddle/blob/d8f7ee8a8474530b456d9a973a5db743cfb2a9ff/package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TS 2.2
WeakMapinterface for ES6 has been changed fromWeakMap<K, V>toWeakMap<K extends object, V>. This changes makes@types/lodashnot working with new ES6 introduced in TS2.2.To keep the backward compatibility with ES5, I think it is safe to rename the
WeakMapdeclaration.I know TS 2.2 is still in RC version now, but many people using it, including me :). So if you think this is too early and also bad idea then feel free to close this PR without merging it.
If this get merged then it's should close #14324.