Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3-random] Update to v1.1.0 #16467

Merged
1 commit merged into from
May 12, 2017
Merged

[d3-random] Update to v1.1.0 #16467

1 commit merged into from
May 12, 2017

Conversation

tomwanzek
Copy link
Contributor

  • [Feature] Update d3-random to minor version 1.1 adding configurable source of pseudo-random numbers.
  • [Chore] Enable strictNullChecks
  • [Chore] Add tslint config.
  • [Chore] Bumped version.

Closes #16300 .

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/d3/d3-random/releases>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dslint/dt.json" }.

* [Feature] Update d3-random to minor version 1.1 adding configurable source of pseudo-randomnumbers.
* [Chore] Enable `strictNullChecks`
* [Chore] Add tslint config.
* [Chore] Bumped version.
@dt-bot
Copy link
Member

dt-bot commented May 11, 2017

types/d3-random/index.d.ts

to authors (@tomwanzek @gustavderdrache @borisyankov). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

@tomwanzek
Copy link
Contributor Author

@gustavderdrache Whenever you have a minute...

@tomwanzek
Copy link
Contributor Author

Related to #11365 .

Copy link
Contributor

@gustavderdrache gustavderdrache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tomwanzek
Copy link
Contributor Author

@andy-ms If you have a second, could you kindly merge this PR. As always, thanks in advance!!! T

@ghost ghost merged commit e251c14 into DefinitelyTyped:master May 12, 2017
@tomwanzek tomwanzek deleted the d3-random-1-1-0 branch May 12, 2017 14:14
@tomwanzek
Copy link
Contributor Author

@andy-ms Somehow, the merge has not triggered a publish to npm/@types for d3-random. Thx in advance for looking into it when you have a sec.

@ghost
Copy link

ghost commented May 13, 2017

Sorry, azure acting up. Ran a manual publish.

@tomwanzek
Copy link
Contributor Author

Thanks a lot! All 👍 for random/zoom/drag.

DABH pushed a commit to DABH/DefinitelyTyped that referenced this pull request May 15, 2017
* [Feature] Update d3-random to minor version 1.1 adding configurable source of pseudo-randomnumbers.
* [Chore] Enable `strictNullChecks`
* [Chore] Add tslint config.
* [Chore] Bumped version.
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants