Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3-zoom/d3-drag] Update to version 1.2/1.1, respectively #16470

Merged
2 commits merged into from
May 12, 2017
Merged

[d3-zoom/d3-drag] Update to version 1.2/1.1, respectively #16470

2 commits merged into from
May 12, 2017

Conversation

tomwanzek
Copy link
Contributor

  • [Feature] Add support of clickDistance(...)
  • [Chore] Bump version number.

Closes #16468 .

@gustavderdrache Another quick one for good measure... 😄

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <https://github.com/d3/d3-zoom/releases>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dslint/dt.json" }.

* [Feature] Add support of `clickDistance(...)`
* [Chore] Bump version number.
@dt-bot
Copy link
Member

dt-bot commented May 11, 2017

types/d3-zoom/index.d.ts

to authors (@tomwanzek @gustavderdrache @borisyankov). Could you review this PR?
👍 or 👎?

Checklist

  • pass the Travis CI test?

Copy link
Contributor

@gustavderdrache gustavderdrache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You weren't kidding about it being a quick review!

* [Feature] Add support for `clickDistance(...)`
* [Chore] Minor version bump
@tomwanzek
Copy link
Contributor Author

I have just added on d3-drag on this PR. It's the exact same change with minor version bump.

@tomwanzek tomwanzek changed the title [d3-zoom] Update to version 1.2 [d3-zoom/d3-drag] Update to version 1.2/1.1, repsectively May 11, 2017
@tomwanzek tomwanzek changed the title [d3-zoom/d3-drag] Update to version 1.2/1.1, repsectively [d3-zoom/d3-drag] Update to version 1.2/1.1, respectively May 11, 2017
@tomwanzek
Copy link
Contributor Author

@gustavderdrache Thanks for the swift turnaround! T

@tomwanzek
Copy link
Contributor Author

@andy-ms If you have a second, could you kindly merge this PR. As always, thanks in advance!!! T

@ghost ghost merged commit 5a67cd5 into DefinitelyTyped:master May 12, 2017
@tomwanzek tomwanzek deleted the d3-zoom-1-2-0 branch May 12, 2017 14:14
@tomwanzek
Copy link
Contributor Author

@andy-ms Somehow, the merge has not triggered a publish to npm/@types for d3-zoom and d3-drag. Thx in advance for looking into it when you have a sec.

DABH pushed a commit to DABH/DefinitelyTyped that referenced this pull request May 15, 2017
…Typed#16470)

* [d3-zoom] Update to version 1.2
* [Feature] Add support of `clickDistance(...)`
* [Chore] Bump version number.

* [d3-drag] Update to version 1.1
* [Feature] Add support for `clickDistance(...)`
* [Chore] Minor version bump
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants