Fixed generics return value of Window and Buffer operators #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generics values where incorrect. The correct result for windowWithXXX operators is Observable<Observable<T>> and for bufferWithXXX it's Observable<T[]>
|
@Igorbek @borisyankov please review this pull request & merge! |
|
@carldebilly You are right! Thanks. |
Igorbek
added a commit
that referenced
this pull request
Feb 18, 2014
Fixed generics return value of Window and Buffer operators
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generics values where incorrect. The correct result for windowWithXXX
operators is Observable<Observable> and for bufferWithXXX it's
Observable<T[]>