New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[node] Add definition for Node.js v8 #17027
Conversation
types/node/index.d.ts to authors (@DefinitelyTyped/DefinitelyTyped @parambirs @robdesideri @tellnes @WilcoBakker Microsoft TypeScript (account can't be detected)). Could you review this PR? Checklist
types/node/v7/index.d.ts Checklist
|
See #16860. |
@andy-ms Now users can add features to declaration for Node.js v7 which doesn't exist in Node.js v7 runtime. There are several problems:
If separated issue (#16860) for Node.js v8 exists, why pull request with util.promisify was merged? |
@ikokostya This solution doesn't seem solve broken runtime anyway cause there are plenty modules that just referencing the latest |
So @yuit @andy-ms what we wait here? Could you provide TODO list of necessary changes for Node.js 8 #16860 (comment)? |
@andy-ms to close the loop. I don't see a reason not to merge this. It'll keep people from adding v8 features to v7 typings. Any objections? |
It seems this has not been published to @types/node npm package yet? The latest version of that package is 7.0.31 |
@magnushiie check again, it's up |
Thanks! |
[node] Add definition for Node.js v8
List of changes:
types/node/index.d.ts
totypes/node/v7/index.d.ts
util.promisify
(introduced by [types/node] Add promisify to util [wip] #16946) fromv7/index.d.ts
, because this function is available since Node.js v8.types/node/index.d.ts
for Node.js v8 - increase the version number in the header.compilerOptions.lib
toes6
intsconfig.json
like intypes/node/v6/tsconfig.json
.Please fill in this template.
npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
.