Export Rx as "rx" module for CommonJS loading #1815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvakame
added a commit
that referenced
this pull request
Mar 9, 2014
Export Rx as "rx" module for CommonJS loading
|
@JoshRosen thanks mate! |
| @@ -354,3 +354,7 @@ declare module Rx { | |||
|
|
|||
| export var AsyncSubject: AsyncSubjectStatic; | |||
| } | |||
|
|
|||
| declare module "rx" { | |||
| export = Rx | |||
There was a problem hiding this comment.
This line is missing a semicolon, although it is optional it seems that all code in DefinitelyTyped adds them...
This was referenced Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exports Rx as "rx" so that
works.
The name
rxmatches the package name in NPM: https://www.npmjs.org/package/rx.