Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: @storybook/addon-options: hierarchySeparator #18253

Merged
merged 5 commits into from
Aug 3, 2017
Merged

fix: @storybook/addon-options: hierarchySeparator #18253

merged 5 commits into from
Aug 3, 2017

Conversation

joscha
Copy link
Contributor

@joscha joscha commented Jul 20, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Add hierarchySeparator to README storybookjs/storybook#1445
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@dt-bot
Copy link
Member

dt-bot commented Jul 20, 2017

types/storybook__addon-options/index.d.ts

Checklist

  • pass the Travis CI test?

@joscha joscha mentioned this pull request Jul 20, 2017
Merged
@joscha
Copy link
Contributor Author

joscha commented Jul 20, 2017

depends on storybookjs/storybook#1383

@typescript-bot typescript-bot added the Unowned This PR touches a package that doesn't have any listed owners. label Jul 20, 2017
@weswigham
Copy link
Contributor

Ping again when the PR for these types is merged into the main project.

@typescript-bot
Copy link
Contributor

This PR has been open and unchanged 5 days without signoff or complaint. This will be merged by a maintainer soon if there are no objections.

@typescript-bot typescript-bot moved this from Unowned to Merge: YSYL in Pull Request Triage Backlog Jul 25, 2017
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Jul 25, 2017
@joscha
Copy link
Contributor Author

joscha commented Jul 25, 2017

@typescript-bot the PR this one is depending on seems to take a little longer. I can close the PR and reopen it later, if that is better.

@joscha
Copy link
Contributor Author

joscha commented Aug 3, 2017

@weswigham this is ready now

@weswigham weswigham merged commit de04212 into DefinitelyTyped:master Aug 3, 2017
@joscha joscha deleted the joscha/fix-storybook-addon-options-hierarchySeparator branch August 3, 2017 03:26
milosdanilov pushed a commit to milosdanilov/DefinitelyTyped that referenced this pull request Aug 5, 2017
@joscha @milosdanilov
fix: @storybook/addon-options: hierarchySeparator (DefinitelyTyped#18253
90e3eae 
)

* fix: @storybook/addon-options: hierarchySeparator

* Update storybook__addon-options-tests.ts

* Update index.d.ts

* Update storybook__addon-options-tests.ts
@typescript-bot typescript-bot removed this from Merge: YSYL in Pull Request Triage Backlog Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

Assignees
No one assigned
Labels
Unmergeable Unmerged The author did not merge the PR when it was ready. Unowned This PR touches a package that doesn't have any listed owners.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joscha @dt-bot @weswigham @typescript-bot