Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[p-queue] introduce typings #18303

Merged
merged 1 commit into from
Jul 22, 2017
Merged

Conversation

BendingBender
Copy link
Contributor

Based on typings proposed in sindresorhus/p-queue#6

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

@dt-bot
Copy link
Member

dt-bot commented Jul 22, 2017

types/p-queue/index.d.ts

Checklist

@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Jul 22, 2017
@weswigham weswigham merged commit 29fc3e0 into DefinitelyTyped:master Jul 22, 2017
@BendingBender BendingBender deleted the p-queue branch July 22, 2017 09:01
@typescript-bot typescript-bot removed this from New Definitions in Pull Request Triage Backlog Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants