Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add types for twitter-stream-channels 1.0.0 #19725

Merged
merged 1 commit into from Sep 15, 2017

Conversation

adrianbardan
Copy link
Contributor

@adrianbardan adrianbardan commented Sep 13, 2017

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, and strictNullChecks set to true.

@dt-bot
Copy link
Member

dt-bot commented Sep 13, 2017

types/twitter-stream-channels/index.d.ts

Checklist

@typescript-bot typescript-bot added this to New Definitions in Pull Request Triage Backlog Sep 13, 2017
@typescript-bot typescript-bot added the New Definition This PR creates a new definition package. label Sep 13, 2017
@@ -0,0 +1,22 @@
{
"compilerOptions": {
Copy link
Contributor

@aozgaa aozgaa Sep 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider creating a tslint.json with dts-gen.

EDIT: misread the file name.

@aozgaa aozgaa merged commit fa1c082 into DefinitelyTyped:master Sep 15, 2017
* @returns {StreamChannels}
* @see https://github.com/topheman/twitter-stream-channels/blob/master/lib/StreamChannels.js#L120
*/
stop(options?: StreamChannels.StreamChannelsOptions): StreamChannels;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only removeAllListeners, should not a generic "StreamChannelsOptions" interface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants