-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types for Cytoscapejs #20511
Merged
Merged
Add types for Cytoscapejs #20511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, OS was restricted to only `linux`. However cytoscape.js does not appear to have any os restrictions defined in it's [`package.json`](https://github.com/cytoscape/cytoscape.js/blob/master/package.json).
Remove Linux-only OS restrictions
That type can only be one of the specified event types.
types/cytoscape/index.d.ts Checklist
|
typescript-bot
added
New Definition
This PR creates a new definition package.
The Travis CI build failed
labels
Oct 12, 2017
@wy193777 Please fix the failures indicated in the Travis CI log. |
This was referenced Oct 13, 2017
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally created by @phreed . I merged it to DefinitelyTyped and fix lint and some other minor problems.