Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $mdTheming service to angular-material #20773

Merged
merged 1 commit into from
Oct 23, 2017

Conversation

mtraynham
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Oct 20, 2017

types/angular-material/index.d.ts

to authors (@blbigelow @PeterHajdu @Dona278 @geertjansen). Could you review this PR?
👍 or 👎?

@mtraynham
Copy link
Contributor Author

Testing angular-material
	Running: node /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/dtslint/bin/index.js
	Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/types/angular-material/index.d.ts
ERROR: 7:26 no-implicit-dependencies Module 'angular' is not listed as dependency in package.json

Not entirely sure why that failed. The index file already imports angular. Is the import broken here?

@ghost
Copy link

ghost commented Oct 20, 2017

@mtrayham Sorry, this looks like a new lint rule. I'll disable it since we use path mapping on DT. (palantir/tslint#3364)

@mtraynham
Copy link
Contributor Author

No worries @andy-ms. Thanks for help!

@geertjansen
Copy link
Contributor

LGTM

@typescript-bot typescript-bot added this to Merge: Express in Pull Request Triage Backlog Oct 23, 2017
@typescript-bot
Copy link
Contributor

Approved by a listed owner. PR ready to merge pending express review by a maintainer.

@sheetalkamat sheetalkamat merged commit b172f59 into DefinitelyTyped:master Oct 23, 2017
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Oct 23, 2017
@mtraynham mtraynham deleted the angular-material branch October 24, 2017 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants