Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading spinner props to react-native-elements ButtonProps #21382

Merged
3 commits merged into from Nov 13, 2017

Conversation

awinograd
Copy link
Contributor

@awinograd awinograd commented Nov 9, 2017

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@dt-bot
Copy link
Member

dt-bot commented Nov 9, 2017

types/react-native-elements/index.d.ts

to authors (@iRoachie @ifiokjr). Could you review this PR?
👍 or 👎?

@RyanCavanaugh
Copy link
Member

@awinograd Please fix the failures indicated in the Travis CI log.

@awinograd
Copy link
Contributor Author

awinograd commented Nov 9, 2017

Hi @RyanCavanaugh, I'm not sure how I could have caused the jenkins failure. Can you point me in the right direction?

Error: mock-knex depends on knex but has a lower required TypeScript version.

I get that locally running npm test on master as well

@ghost
Copy link

ghost commented Nov 9, 2017

Hi @awinograd, that was fixed in a different PR (#21384). See updated failure messages -- just a few lint errors.

@awinograd
Copy link
Contributor Author

@andy-ms i've rebased on master (to get the fix in #21384) and have fixed the lint errors

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Nov 12, 2017
@typescript-bot
Copy link
Contributor

@awinograd Please address the merge conflict.

@awinograd
Copy link
Contributor Author

Merge conflict fixed. Ready for re-review

@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Nov 13, 2017
@ghost ghost merged commit f8e2507 into DefinitelyTyped:master Nov 13, 2017
@awinograd awinograd deleted the patch-1 branch November 13, 2017 20:29
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants