New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading spinner props to react-native-elements ButtonProps #21382
Conversation
@awinograd Please fix the failures indicated in the Travis CI log. |
Hi @RyanCavanaugh, I'm not sure how I could have caused the jenkins failure. Can you point me in the right direction?
I get that locally running |
Hi @awinograd, that was fixed in a different PR (#21384). See updated failure messages -- just a few lint errors. |
@andy-ms i've rebased on master (to get the fix in #21384) and have fixed the lint errors |
@awinograd Please address the merge conflict. |
Merge conflict fixed. Ready for re-review |
npm run lint package-name
(ortsc
if notslint.json
is present).If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. n/a