Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type definition for notyf #21393

Merged
merged 1 commit into from Nov 10, 2017
Merged

Conversation

gurov
Copy link
Contributor

@gurov gurov commented Nov 10, 2017

Please fill in this template.

  • [v] Use a meaningful title for the pull request. Include the name of the package modified.
  • [v] Test the change in your own code. (Compile and run.)
  • [v] Follow the advice from the readme.
  • [v] Avoid common mistakes.
  • [v] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [v] The package does not provide its own types, and you can not add them.
  • [v] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [v] Create it with dts-gen --dt, not by basing it on an existing project.
  • [v] tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@dt-bot
Copy link
Member

dt-bot commented Nov 10, 2017

types/notyf/index.d.ts

Checklist

@RyanCavanaugh RyanCavanaugh added this to New Definitions in Pull Request Triage Backlog Nov 10, 2017
@RyanCavanaugh RyanCavanaugh added the New Definition This PR creates a new definition package. label Nov 10, 2017
@DanielRosenwasser DanielRosenwasser merged commit 8701938 into DefinitelyTyped:master Nov 10, 2017
@DanielRosenwasser
Copy link
Member

Thank you!

@typescript-bot typescript-bot removed this from New Definitions in Pull Request Triage Backlog Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants