Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Auth0 definitions for JS API and widget #2183

Merged
merged 3 commits into from
May 22, 2014

Conversation

robertmclaws
Copy link
Contributor

Please let me know if there is anything I need to do to get NuGet packages made for this PR.

Thanks!

@robertmclaws
Copy link
Contributor Author

Sorry about that... it passed the build locally but Travis CI is a lot more thorough. :)

@Bartvds
Copy link
Collaborator

Bartvds commented May 13, 2014

Cool, thanks for the PR.

Out of curiosity, what did you run to test your edits?

We're looking into making that part both easier and always match with Travis, so some real-world usage info is welcome.

@robertmclaws
Copy link
Contributor Author

I used Visual Studio 2013.2 with WebEssentials and ReSharper 8.2 to do my editing and testing. The compiler there allows for methods/parameters to be implicitly empty without error.

I wouldn't necessarily relax the compilation requirements on your end, if I were you... maybe just provide details in your contributor guidelines for how to configure VS2013 to be just as strict.

Thanks!

@Bartvds
Copy link
Collaborator

Bartvds commented May 13, 2014

Thanks for the info.

We definitely want the --noImplicitAny compiler flag active.

We'll arrange a VS2013 instruction (and for other IDE's too, I think WebStorm has a similar setting).

Ticket: DefinitelyTyped/definitelytyped.github.io#15

@robertmclaws
Copy link
Contributor Author

Is there an ETA on when this can be merged? Thanks!

Bartvds added a commit that referenced this pull request May 22, 2014
Added Auth0 definitions for JS API and widget
@Bartvds Bartvds merged commit df4123e into DefinitelyTyped:master May 22, 2014
@Bartvds
Copy link
Collaborator

Bartvds commented May 22, 2014

Thanks for reminding (and the files of course).

Slipped out of my mailbox, but it is merged.

@robertmclaws
Copy link
Contributor Author

Thanks! I didn't expect you to get to it so quickly, thanks! I had a couple changes I added here before you slipped this one in. #2234

Thanks again!

@Bartvds
Copy link
Collaborator

Bartvds commented May 22, 2014

Ah well, it showed-up in my mailbox and I felt guilty for letting it slip earlier :)

Thanks for your contributions!

@robertmclaws
Copy link
Contributor Author

No worries, thanks a bunch for getting it in so quickly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants