Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts to match library documentation #23117

Merged
1 commit merged into from Jan 23, 2018
Merged

Update index.d.ts to match library documentation #23117

1 commit merged into from Jan 23, 2018

Conversation

jdedwards3
Copy link
Contributor

@jdedwards3 jdedwards3 commented Jan 22, 2018

see this related issue that is now closed:
leongersen/noUiSlider#813

When calling get type should be strings

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not provide its own types, and you can not add them.
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

see this related issue that is now closed: 
leongersen/noUiSlider#813

When calling get type should be strings
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 22, 2018

@jimwards17 Thank you for submitting this PR!

🔔 @bleuarg @lagaffe - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@ghost ghost merged commit e4bb061 into DefinitelyTyped:master Jan 23, 2018
@typescript-bot typescript-bot removed this from Merge: Express in Pull Request Triage Backlog Jan 23, 2018
@jdedwards3 jdedwards3 deleted the patch-1 branch January 4, 2019 02:05
@jdedwards3 jdedwards3 restored the patch-1 branch January 12, 2019 01:49
@jdedwards3 jdedwards3 deleted the patch-1 branch January 12, 2019 02:07
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants