Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing types/yfiles to resolve #23310 #23364

Merged
merged 3 commits into from Feb 2, 2018
Merged

Removing types/yfiles to resolve #23310 #23364

merged 3 commits into from Feb 2, 2018

Conversation

yGuy
Copy link
Contributor

@yGuy yGuy commented Feb 2, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

This has been done help resolving #23310.

@typescript-bot typescript-bot added Unowned This PR touches a package that doesn't have any listed owners. Author is Owner The author of this PR is a listed owner of the package. The Travis CI build failed labels Feb 2, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 2, 2018

@yGuy Thank you for submitting this PR!

Because this PR doesn't have any code reveiwers, a DefinitelyTyped maintainer will be reviewing it in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

@yGuy The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks!

@yGuy
Copy link
Contributor Author

yGuy commented Feb 2, 2018

Huh?! I think I don't understand why the check (all checks) have failed. Actually this looks unrelated to my change, or am I blind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Unowned This PR touches a package that doesn't have any listed owners.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants