Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noModule to @types/react ScriptHTMLAttributes #24691

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Add noModule to @types/react ScriptHTMLAttributes #24691

merged 1 commit into from
Apr 3, 2018

Conversation

stipsan
Copy link
Contributor

@stipsan stipsan commented Apr 3, 2018

React added this in facebook/react#11900
Which is part of the 16.3 release https://github.com/facebook/react/blob/master/CHANGELOG.md#react-dom

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Add noModule boolean attribute facebook/react#11900
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot
Copy link
Contributor

@stipsan Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @morcerf @tkrotoff @DovydasNavickas @onigoetz @richseviora @theruther4d - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Apr 3, 2018
@johnnyreilly johnnyreilly merged commit 978c90a into DefinitelyTyped:master Apr 3, 2018
@johnnyreilly
Copy link
Member

Thanks!

@stipsan
Copy link
Contributor Author

stipsan commented Apr 3, 2018

@johnnyreilly damn I just realized it got added to the wrong element! 😓 I'll follow up with a fix!

stipsan added a commit to stipsan/DefinitelyTyped that referenced this pull request Apr 3, 2018
noModule got added to the wrong element (doh)
mhegazy pushed a commit that referenced this pull request Apr 9, 2018
noModule got added to the wrong element (doh)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants