angular directive changes, still missing #2605

[pocesar]

tabs to spaces, fix white space, separate link and compile interfaces to be casteable

[pocesar]

guess this is related to #2618

[basarat]

this basically makes link compatible with anything that doesn't have pre or post members. E.g. link : 'bad' will compile. I think

[pocesar]

that's the bad side of Javascript, you can have all, and Typescript won't allow you to have all heh. making it (): IDirectivePrePost; doesnt help either.

[basarat]

Here : #2605 you had :

interface IDirectiveLink {
        (): IDirectiveLinkFunction;
        pre?: IDirectiveLinkFunction;
        post?: IDirectiveLinkFunction;
    }

I take it that (): IDirectiveLinkFunction; didn't test well?

In this PR : Seems we are saying either you can have old safety for link OR you can have the new safety for pre/post. If this is the case I prefer the old safety since link is used much more than pre/post. Correct?

[pocesar]

yup, but angular docs say that the best practice is to always return an object of pre/post... that's the confusion.
https://docs.angularjs.org/api/ng/service/$compile#comprehensive-directive-api

Best Practice: It's recommended to use the "directive definition object" form.

[basarat]

It's recommended to use the "directive definition object" form.

I am happy with the compile definition you have added 👍 That can follow the definition object form. Just don't like it for the link function.

[pocesar]

makes sense, will change it then

[basarat]

Awesome. Thanks. One more fix. Don't mark these arguments as optional (http://definitelytyped.org/guides/best-practices.html callback signatures)

[pocesar]

alright
@basarat It seems it's not possible to create an overloaded function declaration, trying to use

    interface IDirectiveLinkFn {
        (
            scope: IScope,
            instanceElement: IAugmentedJQuery,
            instanceAttributes: IAttributes,
            controller: any,
            transclude: ITranscludeFunction
        ): void;
        (
            scope: IScope,
            instanceElement: IAugmentedJQuery,
            instanceAttributes: IAttributes,
            controller: any
        ): void;
        (
            scope: IScope,
            instanceElement: IAugmentedJQuery,
            instanceAttributes: IAttributes
        ): void;
        (
            scope: IScope,
            instanceElement: IAugmentedJQuery
        ): void;
        (
            scope: IScope
        ): void;
        (): void;
    }

but the compiler won't let me use just scope for example

[basarat]

It should be just :

   interface IDirectiveLinkFn {
        (
            scope: IScope,
            instanceElement: IAugmentedJQuery,
            instanceAttributes: IAttributes,
            controller: any,
            transclude: ITranscludeFunction
        ): void;
  }

Demo that it accommodates all:

interface IDirectiveLinkFn {
        (
            scope: any,
            instanceElement: any,
            instanceAttributes: any,
            controller: any,
            transclude: any
        ): void;
  }

  var foo : IDirectiveLinkFn;

  foo = ()=>{};
  foo = (scope)=>{};
  // And so on 

[pocesar]

you are right, I'm overthinking this. The next commit should have fixed it.

[basarat]

@pocesar This doesn't add any value IMHO:

interface IScope1 {
       [index: string]: any;
       $apply(): any;
}
interface IScope2 {
       $apply(): any;
}

var scope1:IScope1;
scope1['foo'] = 123;

var scope2:IScope2;
scope2['foo'] = 123;

[pocesar]

on typescript 1.0.1 with --noImplicitAny, that fails, therefore you should explicitely define that the interface expects anything to be added to it.

test.ts(13,8): error TS7017: Index signature of object type implicitly has an 'any' type.

[basarat]

@pocesar thanks mate! Just wondering about the need for the following:

this: IRootScopeService;

[pocesar]

it's part of the rootscope, "this" always point to the scope itself, like $root points to $rootScope, yadda yadda

[basarat]

it's part of the rootscope, "this" always point to the scope itself,

Indeed it does. Tested : http://jsfiddle.net/vuy3sv0g/