Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest] add toHaveBeenNthCalledWith matcher #26399

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

r3nya
Copy link
Contributor

@r3nya r3nya commented Jun 9, 2018

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: Alias parity for all spy matchers jestjs/jest#5826
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

Context

Issue #26387

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jun 9, 2018
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 9, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 9, 2018

@r3nya Thank you for submitting this PR!

🔔 @NoHomey @jwbay @asvetliakov @alexjoverm @epicallan @ikatyang @wsmd @JamieMason @douglasduteil @AhnpGit @JoshuaKGoldberg @bradleyayers - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@orlandohohmeier
Copy link

I was about to add the types for toHaveBeenNthCalledWith as well. 😸

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Jun 10, 2018
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing unit tests, but there've been a few Jest pull requests lately and it looks like there's already a gap in test coverage.

If you're up for adding tests to jest-tests.ts that would be great! Otherwise I can just add them in a subsequent PR.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jun 10, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jun 10, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@r3nya
Copy link
Contributor Author

r3nya commented Jun 11, 2018

Hey @JoshuaKGoldberg! Thanks for your review. I'm going to add tests for it. ;)

@r3nya
Copy link
Contributor Author

r3nya commented Jun 11, 2018

@JoshuaKGoldberg added test for it. Now everything is ok. 🎉

@typescript-bot typescript-bot moved this from Check and Merge to Needs Author Attention in Pull Request Status Board Jun 11, 2018
@typescript-bot
Copy link
Contributor

@r3nya The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Jun 11, 2018
@minestarks minestarks merged commit 26287b3 into DefinitelyTyped:master Jun 11, 2018
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jun 11, 2018
@r3nya r3nya deleted the jest-23 branch June 11, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Other Approved This PR was reviewed and signed-off by a community member. Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants