d3-quadtree: JsDoc, strictNullChecks and TS 2.3 #27648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trailing whitespace TypeScript Version: 2.3
typescript-bot
added
the
Popular package
|
@denisname Thank you for submitting this PR! 🔔 @tomwanzek @gustavderdrache @borisyankov - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
Just add a |
denisname
changed the title
typescript-bot
moved this from Waiting for Reviewers
to Review
in Pull Request Status Board
typescript-bot
added
the
Unmerged
|
After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience! |
sheetalkamat
approved these changes
Aug 6, 2018
briandk
pushed a commit
to briandk/DefinitelyTyped
that referenced
this pull request
Aug 7, 2018
* Add JsDoc and use default generics * Activate strictNullChecks and use ExpectError * Fix most linting trailing whitespace TypeScript Version: 2.3 * Fix void-return * Add length property to internal and leaf nodes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add JsDoc.
Activate strictNullChecks: type definition where already complete, so I just had to update the tests.
For strictFunctionTypes I have nothing to add.
TS 2.4: use default generics for
quadtree.In tests use
ExpectErrorand change theisLeafwitha.lengthas it is the recommended way in the documentation.Related #23611.
Please fill in this template.