Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added declaration of chrisjpatty/react-dragtastic #27669

Merged
merged 3 commits into from
Aug 3, 2018

Conversation

nscarcella
Copy link
Contributor

  • Added declaration of chrisjpatty/react-dragtastic

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

whatasoda and others added 2 commits July 30, 2018 01:00
* Added declaration of tweetdeck/valiant

* fixed version notation and miss typo.
@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Jul 30, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 30, 2018

@nscarcella Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

],
"noImplicitAny": true,
"noImplicitThis": true,
"strictNullChecks": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is new definition please change this property to true and fix any errors

@@ -0,0 +1,9 @@
{
"extends": "dtslint/dt.json",
"rules": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. This is new definition, so should just extends dtslint/dt.json

@nscarcella
Copy link
Contributor Author

Added the changes @sheetalkamat. Sorry about the strict null issue, I was sure I left the original values as they where. About the semicolon, you can't blame me for trying :P

@typescript-bot typescript-bot moved this from Review to Needs Author Attention in Pull Request Status Board Jul 30, 2018
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback labels Jul 30, 2018
@typescript-bot
Copy link
Contributor

@nscarcella One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

🔔 @sheetalkamat - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label Jul 30, 2018
@sheetalkamat sheetalkamat merged commit 83a4cac into DefinitelyTyped:master Aug 3, 2018
@typescript-bot typescript-bot removed this from Needs Author Attention in Pull Request Status Board Aug 3, 2018
mernxl pushed a commit to mernxl/DefinitelyTyped that referenced this pull request Aug 4, 2018
)

* Added declaration of tweetdeck/valiant (DefinitelyTyped#27385)

* Added declaration of tweetdeck/valiant

* fixed version notation and miss typo.

* lint fixes

* PR fixes
briandk pushed a commit to briandk/DefinitelyTyped that referenced this pull request Aug 7, 2018
)

* Added declaration of tweetdeck/valiant (DefinitelyTyped#27385)

* Added declaration of tweetdeck/valiant

* fixed version notation and miss typo.

* lint fixes

* PR fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package. Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants