-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added declaration of chrisjpatty/react-dragtastic #27669
Added declaration of chrisjpatty/react-dragtastic #27669
Conversation
* Added declaration of tweetdeck/valiant * fixed version notation and miss typo.
@nscarcella Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
types/react-dragtastic/tsconfig.json
Outdated
], | ||
"noImplicitAny": true, | ||
"noImplicitThis": true, | ||
"strictNullChecks": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is new definition please change this property to true and fix any errors
types/react-dragtastic/tslint.json
Outdated
@@ -0,0 +1,9 @@ | |||
{ | |||
"extends": "dtslint/dt.json", | |||
"rules": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. This is new definition, so should just extends dtslint/dt.json
Added the changes @sheetalkamat. Sorry about the strict null issue, I was sure I left the original values as they where. About the semicolon, you can't blame me for trying :P |
@nscarcella One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you! |
🔔 @sheetalkamat - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate? |
) * Added declaration of tweetdeck/valiant (DefinitelyTyped#27385) * Added declaration of tweetdeck/valiant * fixed version notation and miss typo. * lint fixes * PR fixes
) * Added declaration of tweetdeck/valiant (DefinitelyTyped#27385) * Added declaration of tweetdeck/valiant * fixed version notation and miss typo. * lint fixes * PR fixes
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should be present, andtsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.