Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Titanium TypeScript typings to SDK 7.3.0 #27969

Merged
merged 1 commit into from Aug 13, 2018

Conversation

hansemannn
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@hansemannn
Copy link
Contributor Author

cc @janvennemann, let me know if more is required.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 8, 2018

@hansemannn Thank you for submitting this PR!

🔔 @appcelerator @janvennemann - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Aug 8, 2018

@hansemannn The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@janvennemann
Copy link
Contributor

@hansemannn Please remove the ti.map tests as that is an external module. Also remove the double newline at the end of the definition file to end it with only one new line. Also the version in the header needs to be bumped accordingly. Then this should be good 👍

@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Aug 10, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed The Travis CI build failed labels Aug 10, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now, approved!

@typescript-bot typescript-bot moved this from Check and Merge to Review in Pull Request Status Board Aug 11, 2018
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners. and removed Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels Aug 11, 2018
@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Aug 11, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners. labels Aug 11, 2018
@typescript-bot typescript-bot moved this from Check and Merge to Review in Pull Request Status Board Aug 12, 2018
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners. and removed Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels Aug 12, 2018
@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Aug 12, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners. labels Aug 12, 2018
@typescript-bot typescript-bot moved this from Check and Merge to Review in Pull Request Status Board Aug 12, 2018
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners. and removed Owner Approved A listed owner of this package signed off on the pull request. Merge:Express labels Aug 12, 2018
@typescript-bot typescript-bot moved this from Review to Check and Merge in Pull Request Status Board Aug 12, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Other Approved This PR was reviewed and signed-off by a community member. Unowned This PR touches a package that doesn't have any listed owners. labels Aug 12, 2018
@uniqueiniquity
Copy link
Contributor

Congratulations on your first DefinitelyTyped contribution!
Thank you for being a part of the community!

@uniqueiniquity uniqueiniquity merged commit 6cc7cb3 into DefinitelyTyped:master Aug 13, 2018
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants