Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storybook__react] Add parameter types for add-ons #29531

Conversation

do7be
Copy link
Contributor

@do7be do7be commented Oct 8, 2018

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

@do7be
Copy link
Contributor Author

do7be commented Oct 8, 2018

Oh, sorry. This pull request is based on alpha version. So this diffs are incorrect.

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Oct 8, 2018
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Oct 8, 2018
@typescript-bot
Copy link
Contributor

@do7be Thank you for submitting this PR!

🔔 @joscha @wapgear - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@do7be do7be closed this Oct 8, 2018
@typescript-bot typescript-bot removed this from Waiting for Reviewers in Pull Request Status Board Oct 8, 2018
@do7be do7be deleted the fix/storybook-add-story-parameters-types branch October 9, 2018 02:02
@astorije
Copy link
Contributor

@do7be, now that Storybook v4 is out, would you mind re-submitting this?
Maybe switch parameters from any to object?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants