Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pouchdb-upsert: Enable strictFunctionTypes and make the type of the parameter to UpsertDiffCallback more useful. #30494

Merged

Conversation

mattmccutchen
Copy link
Contributor

Addresses https://stackoverflow.com/q/53275861 .

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.) (Compiled the example from here but did not run. The runtime behavior does not appear to be in doubt.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: N/A, improvement to type declarations for the behavior already described by the documentation in the type declaration file.
  • Increase the version number in the header if appropriate: N/A.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }: Already there.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 13, 2018

@mattmccutchen Thank you for submitting this PR!

🔔 @keithdmoore @hotforfeature @apolkingg8 @zamb3zi - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Nov 13, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Nov 13, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants