Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

office-js: Clean up taskpane #30527

Merged
merged 1 commit into from Nov 14, 2018
Merged

office-js: Clean up taskpane #30527

merged 1 commit into from Nov 14, 2018

Conversation

ElizabethSamuel-MSFT
Copy link
Collaborator

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Nov 14, 2018
@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels Nov 14, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 14, 2018

@ElizabethSamuel-MSFT Thank you for submitting this PR!

🔔 @OfficeDev @LanceEa @Zlatkovsky @kbrandl @Rick-Kirkham @AlexJerabek - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

typescript-bot commented Nov 14, 2018

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. and removed Awaiting reviewer feedback labels Nov 14, 2018
@PranavSenthilnathan PranavSenthilnathan merged commit 82874c7 into DefinitelyTyped:master Nov 14, 2018
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Nov 14, 2018
@ElizabethSamuel-MSFT ElizabethSamuel-MSFT deleted the office-js-clean-up-taskpane branch December 5, 2018 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Owner Approved A listed owner of this package signed off on the pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants