svg: Add missing Svg property "preserveAspectRatio" #30618
Conversation
typescript-bot
added
Awaiting reviewer feedback
Author is Owner
|
@mo Thank you for submitting this PR! 🔔 @KonstantinKai @martynaskadisa @janaagaard75 @ssanchezmarc @fhelwanger @umidbekkarimov @moshfeu @prokopcm @tinaroh @binki - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
|
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
| @@ -569,6 +569,10 @@ async () => { | |||
| </Svg> | |||
| ); | |||
|
|
|||
| () => ( | |||
There was a problem hiding this comment.
Why not adding it to the previous test?
There was a problem hiding this comment.
Because "preserveAspectRatio" is an optional attribute on the "Svg" root element and I wanted the test to cover both the "attribute present" and "attribute not present" cases.
typescript-bot
added
Owner Approved
Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. (Compile and run.)
Add or edit tests to reflect the change. (Run with
npm test.)Follow the advice from the readme.
Avoid common mistakes.
Run
npm run lint package-name(ortscif notslint.jsonis present).Provide a URL to documentation or source code which provides context for the suggested changes: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/preserveAspectRatio
https://developer.mozilla.org/en-US/docs/Web/SVG/Element/symbol