Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add movementX and movementY to MouseEvent #31297

Merged
merged 1 commit into from Dec 12, 2018
Merged

Add movementX and movementY to MouseEvent #31297

merged 1 commit into from Dec 12, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2018

React now polyfills movementX and movementY, see facebook/react#9018.

Please consider this to be a FYI/feature request (add these fields) if the PR doesn't match your standards.

React now polyfills `movementX` and `movementY`, see facebook/react#6723.
@ghost ghost requested a review from johnnyreilly as a code owner December 12, 2018 09:09
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Dec 12, 2018
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Dec 12, 2018
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 12, 2018

@tomashubelbauermicrosoft Thank you for submitting this PR!

🔔 @johnnyreilly @bbenezech @pzavolinsky @digiguru @ericanderson @tkrotoff @DovydasNavickas @onigoetz @theruther4d @guilhermehubner @ferdaber @jrakotoharisoa @pascaloliv @Hotell @franklixuefei @Kovensky - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Dec 12, 2018
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Dec 12, 2018
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@jessetrinity jessetrinity merged commit 2ed75e4 into DefinitelyTyped:master Dec 12, 2018
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Dec 12, 2018
@ghost ghost deleted the patch-1 branch December 13, 2018 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants