Create type definitions for react-filepond

[0livare]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

• The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
• If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
• Create it with dts-gen --dt, not by basing it on an existing project.
  • ❓ I'm not sure what this means exactly
• tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

[0livare]

While running npm run lint react-filepond, I currently get an error that I'm hoping someone might be able to help with:

Error: C:/dev/DefinitelyTyped/types/react-filepond/index.d.ts:22:1
ERROR: 22:1   strict-export-declare-modifiers  'declare' keyword is redundant here. See: https://github.com/Microsoft/dtslint/blob/master/docs/strict-export-declare-modifiers.md

At first glance it seems simple enough to remove the declare, however, if I remove it, I get a different error, A 'declare' modifier is required for a top level declaration in a .d.ts file. So I'm not sure how to handle this contradiction.

My goal is simply to avoid duplicating the File type within this module. Because File refers to the JS interface, but react-filepond also exports a type called File, I believe that I need to use it locally as one name, I've chosen FilePondFile, but export it as the name that matches that one that the package exports, File.

[typescript-bot]

@zposten Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

[typescript-bot]

@zposten The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[typescript-bot]

@zposten I haven't seen anything from you in a while and this PR currently has problems that prevent it from being merged. The PR will be closed tomorrow if there aren't new commits to fix the issues.

[0livare]

@typescript-bot Please don't close this PR. I'm looking for assistance to resolve the one error, as described above.

[0livare]

@sandersn Would you be able to help me with the seemingly lose-lose error described above?

[typescript-bot]

@zposten The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

[sandersn]

@zposten I think tslint (or perhaps our custom rules in dtslint) was in a bad state for a day or so. I think that's why the error went away for the recent run of the build.

[kurtgn]

@zposten Hey Zach - I'm now trying to convert my Filepond components from JSX to TSX, and running into type errors. Specifically, my server parameter consists of callbacks which work with original React-Filepond but are not allowed by TS types. Example:

            <FilePond
                ref={(instance) => {this.fpInstance = instance}}
                server={{

                    /**
                     * When user hits revert - the parent component should receive its old URL
                     */
                    revert: (uniqueFileId: string, load: () => void) => {

                        this.props.updateUrl(this.state.oldImageUrl);
                        // Should call the load method when done, no parameters required
                        load();
                    },
                }}
            />

This fails because revert only accepts string | ServerUrl types. Would you mind adding callback types to the server parameters as well?

Thanks!

[0livare]

@kurtgn I see now why you didn't want to make this change yourself, it was kind of a 🐻 lol. But it should be done now, check out #35291!