-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove webdriverio. Bundles their own types since 5.0.0 #32490
remove webdriverio. Bundles their own types since 5.0.0 #32490
Conversation
@MrOggy85 Thank you for submitting this PR! 🔔 @nmalaguti @timbru31 @fsmedberg-tc @tanvirislam06 @daveparslow @phil-lgr - please review this PR in the next few days. Be sure to explicitly select If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead. |
Sad, but true :) |
A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped! |
@uniqueiniquity - can you close the mentioned issues above? |
@timbru31 Done! Thanks for keeping track of those. |
Seems this breaks tests of chai-webdriverio (see CI of #32159):
Seems chai-webdriverio depends on v4 of webdriverio therefore using the included typings of v5 of webdriverio seems to be wrong there. |
We should probably revert that change to remove and keep the definitely
typed for v4
…On Mon, Jan 28, 2019 at 11:58 AM Gerhard Stöbich ***@***.***> wrote:
Seems this breaks tests of chai-webdriverio (see CI of #32159
<#32159>):
/home/travis/build/DefinitelyTyped/DefinitelyTyped/types/chai-webdriverio/index.d.ts:6:23
ERROR: 6:23 expect ***@***.*** compile error:
Cannot find type definition file for 'webdriverio'.
ERROR: 22:38 expect ***@***.*** compile error:
Cannot find namespace 'WebdriverIO'.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#32490 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIau1LhwRz9DOF2Wy7h9SG2ygFyu6U45ks5vH1ZlgaJpZM4aTTKU>
.
|
I updated the whitelist in types-publisher to allow @types/webdriverio and submitted #32572 to fix this. |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).If removing a declaration:
notNeededPackages.json
.