Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webdriverio. Bundles their own types since 5.0.0 #32490

Merged
merged 1 commit into from Jan 25, 2019
Merged

remove webdriverio. Bundles their own types since 5.0.0 #32490

merged 1 commit into from Jan 25, 2019

Conversation

MrOggy85
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jan 25, 2019
@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Jan 25, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 25, 2019

@MrOggy85 Thank you for submitting this PR!

🔔 @nmalaguti @timbru31 @fsmedberg-tc @tanvirislam06 @daveparslow @phil-lgr - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@timbru31
Copy link
Contributor

Sad, but true :)

@timbru31
Copy link
Contributor

This would/should also close the following issues: #32479, #30313, #27190, #26841, #25186, #21358, #21118, #19100, #14306, #13476

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jan 25, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jan 25, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@uniqueiniquity uniqueiniquity merged commit 2c5594d into DefinitelyTyped:master Jan 25, 2019
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Jan 25, 2019
@timbru31
Copy link
Contributor

@uniqueiniquity - can you close the mentioned issues above?

@uniqueiniquity
Copy link
Contributor

@timbru31 Done! Thanks for keeping track of those.

@Flarna
Copy link
Contributor

Flarna commented Jan 28, 2019

Seems this breaks tests of chai-webdriverio (see CI of #32159):

/home/travis/build/DefinitelyTyped/DefinitelyTyped/types/chai-webdriverio/index.d.ts:6:23
ERROR: 6:23   expect  TypeScript@next compile error: 
Cannot find type definition file for 'webdriverio'.
ERROR: 22:38  expect  TypeScript@next compile error: 
Cannot find namespace 'WebdriverIO'.

Seems chai-webdriverio depends on v4 of webdriverio therefore using the included typings of v5 of webdriverio seems to be wrong there.
Is it possible to keep the v4 typings here? Or how is this fixed usually?

@daveparslow
Copy link
Contributor

daveparslow commented Jan 28, 2019 via email

@rbuckton
Copy link
Collaborator

I updated the whitelist in types-publisher to allow @types/webdriverio and submitted #32572 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants