Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[is-online] Remove types #33560

Merged
merged 1 commit into from Mar 4, 2019
Merged

[is-online] Remove types #33560

merged 1 commit into from Mar 4, 2019

Conversation

BendingBender
Copy link
Contributor

If removing a declaration:

  • If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)
  • Delete the package's directory.
  • Add it to notNeededPackages.json.

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board Mar 3, 2019
@typescript-bot typescript-bot added the Author is Owner The author of this PR is a listed owner of the package. label Mar 3, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 3, 2019 •
edited

@BendingBender Thank you for submitting this PR!

Pull requests from definition owners are typically merged after quick review from a DefinitelyTyped maintainer once the CI passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

SimonSchick
SimonSchick approved these changes Mar 3, 2019
View reviewed changes
Copy link
Contributor

@SimonSchick SimonSchick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wew

@typescript-bot typescript-bot added the Other Approved This PR was reviewed and signed-off by a community member. label Mar 3, 2019
@sandersn sandersn merged commit ce016b6 into DefinitelyTyped:master Mar 4, 2019
@BendingBender BendingBender deleted the remove-is-online branch March 4, 2019 17:56
@typescript-bot typescript-bot removed this from Check and Merge in Pull Request Status Board Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonSchick SimonSchick SimonSchick approved these changes

Assignees
No one assigned
Labels
Author is Owner The author of this PR is a listed owner of the package. Other Approved This PR was reviewed and signed-off by a community member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BendingBender @typescript-bot @SimonSchick @sandersn