Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qunit] Add ES6 import support #35350

Closed
wants to merge 2 commits into from

Conversation

mike-north
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • Increase the version number in the header if appropriate.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

This PR makes it possible to explicitly import from QUnit using ES6 module syntax

import { module, test } from 'qunit';

This involved some significant refactoring because the previous state of these types involved no exports (adding the first export broke the implicit availability of a global QUnit namespace)

Additionally, in response to user feedback, I've added some API documentation to the Hooks and NestedHooks interfaces, in an effort to avoid possible confusion between the two.

cc: @scalvert

@typescript-bot typescript-bot added this to Check and Merge in Pull Request Status Board May 10, 2019
@typescript-bot typescript-bot added Awaiting reviewer feedback Author is Owner The author of this PR is a listed owner of the package. labels May 10, 2019
@typescript-bot
Copy link
Contributor

@mike-north Thank you for submitting this PR!

🔔 @waratuman @sechel - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@mike-north mike-north closed this May 10, 2019
Pull Request Status Board automation moved this from Check and Merge to Done May 10, 2019
@scalvert
Copy link
Contributor

Thanks for this, @mike-north!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants