Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: Update GraphQLFormattedError #36205

Merged
merged 1 commit into from Jun 16, 2019
Merged

Conversation

jednano
Copy link
Contributor

@jednano jednano commented Jun 14, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36205 diff
Batch compilation
Type count 3181 3186 +0.2%
Assignability cache size 169 169 0.0%
Subtype cache size 0 0
Identity cache size 0 0
Language service
Samples taken 230 46 -80.0%
Identifiers in tests 46 46 0.0%
getCompletionsAtPosition
    Mean duration (ms) 185.9 183.1 -1.5%
    Median duration (ms) 172.1 182.5 +6.0%
    Mean CV 20.7%
    Worst duration (ms) 222.9 231.5 +3.8%
    Worst identifier utilities_index_tests error_GraphQLError
getQuickInfoAtPosition
    Mean duration (ms) 183.2 177.0 -3.4%
    Median duration (ms) 168.9 175.5 +3.9%
    Mean CV 19.3%
    Worst duration (ms) 226.6 221.2 -2.4%
    Worst identifier utilities_TypeInfo_tests utilities_assertValidName_tests
System information
Node version v10.15.3 v10.15.3
CPU count 2 2
CPU speed 2.294 GHz 2.397 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture x64 x64
Memory 6.8 GiB 6.8 GiB
Platform linux linux
Release 4.15.0-1041-azure 4.15.0-1045-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Jun 14, 2019
@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Awaiting reviewer feedback labels Jun 14, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jun 14, 2019

@jedmao Thank you for submitting this PR!

🔔 @TonyPythoneer @calebmer @intellix @firede @kepennar @freiksenet @IvanGoncharov @DxCx @rportugal @tgriesser @dyst5422 @adnsio @divyenduz @bradzacher @clayne11 @JCMais @langpavel @mc0 @martijnwalraven - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Jun 14, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Jun 14, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@rbuckton rbuckton merged commit 1e4b5fa into DefinitelyTyped:master Jun 16, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Jun 16, 2019
@typescript-bot
Copy link
Contributor

I just published @types/graphql@14.2.1 to npm.

@jednano jednano deleted the graphql branch June 16, 2019 07:39
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this pull request May 24, 2021
This change was made back when TS typings was hosted on DefinetlyTyped
see DefinitelyTyped/DefinitelyTyped#36205
If such function is requested it should be implemented similar to
extensions in `GraphQL*Type` classes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants