Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ghost-storage-base] fix StorageBase import #36895

Merged
merged 1 commit into from Jul 15, 2019
Merged

[ghost-storage-base] fix StorageBase import #36895

merged 1 commit into from Jul 15, 2019

Conversation

thde
Copy link
Contributor

@thde thde commented Jul 15, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #36895 diff
Batch compilation
Memory usage (MiB) 60.6 62.1 +2.5%
Type count 9341 9373 +0.3%
Assignability cache size 3018 3018 0.0%
Subtype cache size 4 4 0.0%
Identity cache size 1 1 0.0%
Language service
Samples taken 54 54 0.0%
Identifiers in tests 54 54 0.0%
getCompletionsAtPosition
    Mean duration (ms) 337.6 332.1 -1.6%
    Median duration (ms) 339.0 328.6 -3.1%
    Mean CV 13.3% 14.6% +9.8%
    Worst duration (ms) 402.3 393.3 -2.2%
    Worst identifier MyCustomAdapter storage
getQuickInfoAtPosition
    Mean duration (ms) 349.7 357.6 +2.2%
    Median duration (ms) 352.7 352.7 0.0%
    Mean CV 15.7% 15.0% -4.0%
    Worst duration (ms) 403.7 438.7 +8.7%
    Worst identifier req image

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added this to Needs Author Attention in Pull Request Status Board Jul 15, 2019
@typescript-bot typescript-bot added Unowned This PR touches a package that doesn't have any listed owners. The Travis CI build failed labels Jul 15, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 15, 2019

@thde Thank you for submitting this PR!

Pull requests from definition owners are typically merged after quick review from a DefinitelyTyped maintainer once the CI passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 15, 2019

@thde The Travis CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. and removed Unowned This PR touches a package that doesn't have any listed owners. labels Jul 15, 2019
@typescript-bot typescript-bot moved this from Needs Author Attention to Check and Merge in Pull Request Status Board Jul 15, 2019
@typescript-bot
Copy link
Contributor

Since you're a listed owner and the build passed, this PR is fast-tracked. A maintainer will merge shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@andrewbranch andrewbranch merged commit d0f9f81 into DefinitelyTyped:master Jul 15, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Jul 15, 2019
@typescript-bot
Copy link
Contributor

I just published @types/ghost-storage-base@0.0.1 to npm.

@thde thde deleted the fix-ghost-storage-base branch July 21, 2019 18:46
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants