Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types for zdog #36905

Merged
merged 2 commits into from
Jul 15, 2019
Merged

Add types for zdog #36905

merged 2 commits into from
Jul 15, 2019

Conversation

demensky
Copy link
Contributor

Please fill in this template.

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • tslint.json should be present, and tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to zdog with its source on master.

Comparison details 📊
Batch compilation
Type count 10578
Assignability cache size 34458
Subtype cache size 5
Identity cache size 3
Language service measurements
Samples taken 476
Identifiers in tests 476
getCompletionsAtPosition
    Mean duration (ms) 373.7
    Median duration (ms) 371.5
    Mean CV 14.0%
    Worst duration (ms) 483.6
    Worst identifier canvas
getQuickInfoAtPosition
    Mean duration (ms) 362.9
    Median duration (ms) 359.4
    Mean CV 13.6%
    Worst duration (ms) 492.2
    Worst identifier Shape
System information
Node version v10.16.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1047-azure

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Jul 15, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 15, 2019

@demensky Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from be90de5:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to zdog with its source on master.

Comparison details 📊
Batch compilation
Type count 10578
Assignability cache size 34458
Subtype cache size 5
Identity cache size 3
Language service measurements
Samples taken 476
Identifiers in tests 476
getCompletionsAtPosition
    Mean duration (ms) 340.3
    Median duration (ms) 338.9
    Mean CV 14.8%
    Worst duration (ms) 425.6
    Worst identifier Box
getQuickInfoAtPosition
    Mean duration (ms) 332.6
    Median duration (ms) 331.4
    Mean CV 14.7%
    Worst duration (ms) 445.3
    Worst identifier y
System information
Node version v10.16.0
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1047-azure

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the JSDoc and the tests 👍

@andrewbranch andrewbranch merged commit 3ad3eef into DefinitelyTyped:master Jul 15, 2019
Pull Request Status Board automation moved this from Review to Done Jul 15, 2019
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
* Add types for zdog

* Fix dtslint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants