Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for TS #32558 #37167

Merged
merged 1 commit into from
Jul 29, 2019
Merged

Prepare for TS #32558 #37167

merged 1 commit into from
Jul 29, 2019

Conversation

ahejlsberg
Copy link
Collaborator

Prepare baconjs tests for microsoft/TypeScript#32558.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 26, 2019

@ahejlsberg Thank you for submitting this PR!

🔔 @alexander-matsievsky @Gekkio - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #37167 diff
Batch compilation
Memory usage (MiB) 136.1 140.2 +3.0%
Type count 35912 36176 +0.7%
Assignability cache size 35152 35225 +0.2%
Subtype cache size 423 423 0.0%
Identity cache size 565 564 -0.2%
Language service
Samples taken 877 883 +0.7%
Identifiers in tests 877 883 +0.7%
getCompletionsAtPosition
    Mean duration (ms) 945.9 941.4 -0.5%
    Median duration (ms) 905.0 905.7 +0.1%
    Mean CV 7.6% 7.4% -3.0%
    Worst duration (ms) 1498.8 1457.0 -2.8%
    Worst identifier $ $
getQuickInfoAtPosition
    Mean duration (ms) 970.3 956.5 -1.4%
    Median duration (ms) 919.9 916.5 -0.4%
    Mean CV 8.8% 8.8% +0.7%
    Worst duration (ms) 1415.9 1429.4 +0.9%
    Worst identifier retry onValue

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@ahejlsberg ahejlsberg merged commit 47b7924 into master Jul 29, 2019
Pull Request Status Board automation moved this from Waiting for Reviewers to Done Jul 29, 2019
@ahejlsberg ahejlsberg deleted the prepare-for-ts32558 branch July 29, 2019 18:34
iRON5 pushed a commit to iRON5/DefinitelyTyped that referenced this pull request Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants