Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jquery] Test CI failure #37168

Closed

Conversation

leonard-thieu
Copy link
Contributor

Testing #37163

@leonard-thieu leonard-thieu deleted the jquery/test-ci branch July 26, 2019 22:42
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

Comparison details 📊
master #37168 diff
Batch compilation
Memory usage (MiB) 143.9 139.2 -3.3%
Type count 72120 72120 0.0%
Assignability cache size 39560 39560 0.0%
Subtype cache size 4920 4920 0.0%
Identity cache size 201 201 0.0%
Language service
Samples taken 4466 4462 -0.1%
Identifiers in tests 18648 18648 0.0%
getCompletionsAtPosition
    Mean duration (ms) 765.0 765.9 +0.1%
    Median duration (ms) 746.1 747.3 +0.2%
    Mean CV 0.0% 0.0%
    Worst duration (ms) 1585.2 1487.9 -6.1%
    Worst identifier document $
getQuickInfoAtPosition
    Mean duration (ms) 840.6 840.7 0.0%
    Median duration (ms) 788.0 789.7 +0.2%
    Mean CV 0.0% 0.0%
    Worst duration (ms) 1721.2 1674.4 -2.7%
    Worst identifier $ index

It looks like nothing changed too much. I’m pretty lenient since I’m still an experiment, so take a look anyways and make sure nothing looks out of place.


If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants