[office-js, office-js-preview] Clarifying numberFormatLocal description

[AlexJerabek]

Please fill in this template.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code. (Compile and run.)
• Add or edit tests to reflect the change. (Run with npm test.)
• Follow the advice from the readme.
• Avoid common mistakes.
• Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

• Provide a URL to documentation or source code which provides context for the suggested changes: <>
• If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
• If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }.

[typescript-bot]

@AlexJerabek Thank you for submitting this PR!

🔔 @OfficeDev @LanceEa @Zlatkovsky @kbrandl @Rick-Kirkham @ElizabethSamuel-MSFT - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

[typescript-bot]

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

[typescript-bot]

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

office-js-preview/v1

	master	#37410	diff
Batch compilation
Type count	19497	19522	+0.1%
Assignability cache size	33205	33205	0.0%
Subtype cache size	45	45	0.0%
Identity cache size	4	4	0.0%
Language service
Samples taken	2730	546	-80.0%
Identifiers in tests	546	546	0.0%
getCompletionsAtPosition
Mean duration (ms)	871.6	1028.5	+18.0%
Median duration (ms)	835.3	1061.3	+27.0% 🔸
Mean CV		10.0%
Worst duration (ms)	1039.8	1175.4	+13.0%
Worst identifier	i	resolve
getQuickInfoAtPosition
Mean duration (ms)	857.0	1015.4	+18.5%
Median duration (ms)	824.8	1075.8	+30.4% 🔸
Mean CV		9.1%
Worst duration (ms)	1007.7	1178.4	+16.9%
Worst identifier	i	i
System information
Node version	v10.15.3	v10.16.0
CPU count	2	2
CPU speed	2.294 GHz	2.294 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1041-azure	4.15.0-1051-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

Looks like there were a couple significant differences—take a look at median duration for getting completions at a position and median duration for getting quick info at a position to make sure everything looks ok.

office-js/v1

	master	#37410	diff
Batch compilation
Type count	19046	19046	0.0%
Assignability cache size	33163	33163	0.0%
Subtype cache size	45	45	0.0%
Identity cache size	4	4	0.0%
Language service
Samples taken	2730	546	-80.0%
Identifiers in tests	546	546	0.0%
getCompletionsAtPosition
Mean duration (ms)	925.9	1011.5	+9.2%
Median duration (ms)	849.9	1089.6	+28.2% 🔸
Mean CV		9.4%
Worst duration (ms)	1125.0	1200.3	+6.7%
Worst identifier	OfficeExtension	searchResults
getQuickInfoAtPosition
Mean duration (ms)	920.1	998.8	+8.6%
Median duration (ms)	849.6	853.2	+0.4%
Mean CV		9.1%
Worst duration (ms)	1069.4	1186.2	+10.9%
Worst identifier	items	i
System information
Node version	v10.15.3	v10.16.0
CPU count	2	2
CPU speed	2.294 GHz	2.294 GHz
CPU model	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz	Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture	x64	x64
Memory	6.8 GiB	6.8 GiB
Platform	linux	linux
Release	4.15.0-1041-azure	4.15.0-1051-azure

First off, note that the system varied slightly between these two runs, so you’ll have to take these measurements with a grain of salt.

Looks like there were a couple significant differences—take a look at median duration for getting completions at a position to make sure everything looks ok.

---

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

[typescript-bot]

I just published @types/office-js@1.0.24 to npm.

[typescript-bot]

I just published @types/office-js-preview@1.0.28 to npm.