Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @types/async-eventemitter #38203

Merged
merged 8 commits into from Sep 27, 2019
Merged

add @types/async-eventemitter #38203

merged 8 commits into from Sep 27, 2019

Conversation

patarapolw
Copy link
Contributor

@patarapolw patarapolw commented Sep 7, 2019

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • Create it with dts-gen --dt, not by basing it on an existing project.
  • Represents shape of module/library correctly
  • tslint.json should be present and it shouldnt have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick performance metrics against master and your PR. This is still an experiment, so don’t panic if I say something crazy! I’m still learning how to interpret these metrics.

Let’s review the numbers, shall we?

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2270
Assignability cache size 231
Subtype cache size 2
Identity cache size 0
Language service measurements
Samples taken 44
Identifiers in tests 44
getCompletionsAtPosition
    Mean duration (ms) 94.0
    Median duration (ms) 84.8
    Mean CV 24.9%
    Worst duration (ms) 138.3
    Worst identifier resolve
getQuickInfoAtPosition
    Mean duration (ms) 89.9
    Median duration (ms) 84.7
    Mean CV 25.5%
    Worst duration (ms) 109.3
    Worst identifier Promise
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

If you have any questions or comments about me, you can ping @andrewbranch. Have a nice day!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 5dc1a24:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2267
Assignability cache size 231
Subtype cache size 2
Identity cache size 0
Language service measurements
Samples taken 44
Identifiers in tests 44
getCompletionsAtPosition
    Mean duration (ms) 87.6
    Median duration (ms) 84.1
    Mean CV 30.4%
    Worst duration (ms) 112.0
    Worst identifier emit
getQuickInfoAtPosition
    Mean duration (ms) 83.8
    Median duration (ms) 81.7
    Mean CV 29.4%
    Worst duration (ms) 100.5
    Worst identifier emit
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 7dfe35d:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2268
Assignability cache size 236
Subtype cache size 2
Identity cache size 0
Language service measurements
Samples taken 44
Identifiers in tests 44
getCompletionsAtPosition
    Mean duration (ms) 98.7
    Median duration (ms) 83.7
    Mean CV 26.5%
    Worst duration (ms) 126.8
    Worst identifier resolve
getQuickInfoAtPosition
    Mean duration (ms) 93.2
    Median duration (ms) 87.8
    Mean CV 21.5%
    Worst duration (ms) 118.8
    Worst identifier resolve
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

@typescript-bot typescript-bot added New Definition This PR creates a new definition package. Awaiting reviewer feedback labels Sep 7, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Sep 7, 2019

@patarapolw Thank you for submitting this PR!

Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes.

In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 12b5ea3:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2337
Assignability cache size 257
Subtype cache size 2
Identity cache size 0
Language service measurements
Samples taken 40
Identifiers in tests 40
getCompletionsAtPosition
    Mean duration (ms) 99.2
    Median duration (ms) 77.7
    Mean CV 25.9%
    Worst duration (ms) 140.8
    Worst identifier data
getQuickInfoAtPosition
    Mean duration (ms) 96.1
    Median duration (ms) 84.2
    Mean CV 26.0%
    Worst duration (ms) 128.2
    Worst identifier resolve
System information
Node version v10.16.3
CPU count 2
CPU speed 2.397 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v3 @ 2.40GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label Sep 13, 2019
@typescript-bot
Copy link
Contributor

After 5 days, no one has reviewed the PR 😞. A maintainer will be reviewing the PR in the next few days and will either merge it or request revisions. Thank you for your patience!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from 88d0295:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2352
Assignability cache size 256
Subtype cache size 2
Identity cache size 0
Language service measurements
Samples taken 40
Identifiers in tests 40
getCompletionsAtPosition
    Mean duration (ms) 98.0
    Median duration (ms) 76.8
    Mean CV 27.5%
    Worst duration (ms) 124.9
    Worst identifier resolve
getQuickInfoAtPosition
    Mean duration (ms) 95.2
    Median duration (ms) 84.1
    Mean CV 25.3%
    Worst duration (ms) 128.3
    Worst identifier resolve
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

@typescript-bot typescript-bot added Unmerged The author did not merge the PR when it was ready. and removed Unmerged The author did not merge the PR when it was ready. labels Sep 15, 2019
types/async-eventemitter/index.d.ts Outdated Show resolved Hide resolved
types/async-eventemitter/index.d.ts Outdated Show resolved Hide resolved
@typescript-bot typescript-bot moved this from Review to Needs Author Attention in Pull Request Status Board Sep 24, 2019
@typescript-bot typescript-bot added Revision needed This PR needs code changes before it can be merged. and removed Awaiting reviewer feedback Unmerged The author did not merge the PR when it was ready. labels Sep 24, 2019
@typescript-bot
Copy link
Contributor

@patarapolw One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits or comments. Thank you!

@typescript-bot
Copy link
Contributor

Updated numbers for you here from d831fae:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2370
Assignability cache size 262
Subtype cache size 2
Identity cache size 0
Language service measurements
Samples taken 46
Identifiers in tests 46
getCompletionsAtPosition
    Mean duration (ms) 96.1
    Median duration (ms) 81.7
    Mean CV 30.6%
    Worst duration (ms) 124.9
    Worst identifier emit
getQuickInfoAtPosition
    Mean duration (ms) 92.1
    Median duration (ms) 85.9
    Mean CV 25.7%
    Worst duration (ms) 118.5
    Worst identifier ee
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1055-azure

@typescript-bot
Copy link
Contributor

🔔 @uniqueiniquity - Thanks for your review of this PR! Can you please look at the new code and update your review status if appropriate?

@typescript-bot
Copy link
Contributor

Updated numbers for you here from ba24370:

These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to async-eventemitter with its source on master.

Comparison details 📊
Batch compilation
Type count 2376
Assignability cache size 275
Subtype cache size 5
Identity cache size 1
Language service measurements
Samples taken 46
Identifiers in tests 46
getCompletionsAtPosition
    Mean duration (ms) 98.8
    Median duration (ms) 70.5
    Mean CV 27.3%
    Worst duration (ms) 149.4
    Worst identifier resolve
getQuickInfoAtPosition
    Mean duration (ms) 98.0
    Median duration (ms) 71.6
    Mean CV 25.6%
    Worst duration (ms) 127.3
    Worst identifier emit
System information
Node version v10.16.3
CPU count 2
CPU speed 2.294 GHz
CPU model Intel(R) Xeon(R) CPU E5-2673 v4 @ 2.30GHz
CPU Architecture x64
Memory 6.8 GiB
Platform linux
Release 4.15.0-1059-azure

@uniqueiniquity
Copy link
Contributor

Congratulations on your first DefinitelyTyped contribution!
Thank you for being a part of the community!

@uniqueiniquity uniqueiniquity merged commit cc2af58 into DefinitelyTyped:master Sep 27, 2019
Pull Request Status Board automation moved this from Needs Author Attention to Done Sep 27, 2019
@typescript-bot
Copy link
Contributor

I just published @types/async-eventemitter@0.2.0 to npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Definition This PR creates a new definition package. Revision needed This PR needs code changes before it can be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants