-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(puppeteer): 2.0 #40284
feat(puppeteer): 2.0 #40284
Conversation
@SimonSchick Thank you for submitting this PR! Because this is a new definition, a DefinitelyTyped maintainer will be reviewing this PR in the next few days once the Travis CI build passes. In the meantime, if the build fails or a merge conflict occurs, I'll let you know. Have a nice day! |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@RyanCavanaugh what's the current timeline for allowing removing typings? Would you recommend I alter my PR to not remove the v0 ones? I kinda want this PR done 🙂 |
I’m waiting with bated breath for this one! As an aside, if you’ve bumped up the minimum TypeScript version to 3.0, it might make sense to use tuple types for things like |
Feel free to suggest the diff and/or point me to your fork with the commit (I can cherrypick it) |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? puppeteer/v2These typings are for a package that doesn’t yet exist on master, so I don’t have anything to compare against yet! In the future, I’ll be able to compare PRs to puppeteer with its source on master. Comparison details for puppeteer/v2 📊
puppeteer/v1Comparison details for puppeteer/v1 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
I’ve pushed the (no longer WIP) changes to my fork. I was going to open a PR against your branch, but that became difficult because I had also rebased to pull in the changes from I also just realized that I’ve marked it as requiring 3.1 or greater when I actually meant 3.0. |
The correct branch: https://github.com/Aankhen/DefinitelyTyped/commits/add-ts3.0-puppeteer-types |
@Aankhen I tried to manually apply the diff from the last commit, unfortunately I'm getting a few errors, specifically on page.evaluate* calls, see my |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
Where are you getting the errors? If you mean you’re getting TypeScript errors complaining about the rest args, I got the same ones, because it won’t be parsed by 3.0 by default. I believe it will only be parsed by 3.0 when you run the tests. |
I'm using 3.6 in vscode, I'd ask you to checkout my branch and see for yourself. |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
@SimonSchick The Travis CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! |
I’ve checked out SimonSchick/DefinitelyTyped@3a84f88 and I’ve got |
Thanks! That’s why I was asking where the error was, heh. I spent a few hours on this and fixed that, but the complexity keeps increasing, and it’s contagious. I think it’s something a more experienced developer would have to implement. For the moment, I’m going to drop the idea. Thank you for trying to integrate the changes, though. |
I just published |
I just published |
I just published |
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.Rinse and repeat (one last time) #40061
Changes:
Rationale:
any
tounknown
for improved type safety.