Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slick-carousel: Provide typing for the focusOnChange property. #41148

Merged
merged 1 commit into from Dec 20, 2019

Conversation

altearius
Copy link
Contributor

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/kenwheeler/slick/#settings
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.
  • If you are making substantial changes, consider adding a tslint.json containing { "extends": "dtslint/dt.json" }. If for reason the any rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.

@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #41148 diff
Batch compilation
Memory usage (MiB) 93.3 92.6 -0.8%
Type count 16089 16089 0%
Assignability cache size 33376 33376 0%
Language service
Samples taken 235 236 0%
Identifiers in tests 235 236 0%
getCompletionsAtPosition
    Mean duration (ms) 415.9 419.7 +0.9%
    Mean CV 9.3% 9.3%
    Worst duration (ms) 520.7 506.3 -2.8%
    Worst identifier on slick
getQuickInfoAtPosition
    Mean duration (ms) 414.5 419.3 +1.2%
    Mean CV 9.7% 9.4% -3.1%
    Worst duration (ms) 506.5 511.2 +0.9%
    Worst identifier on slidesToShow

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label Dec 19, 2019
@typescript-bot typescript-bot added this to Waiting for Reviewers in Pull Request Status Board Dec 19, 2019
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 19, 2019

@altearius Thank you for submitting this PR!

🔔 @Kocal - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

@typescript-bot typescript-bot moved this from Waiting for Reviewers to Check and Merge in Pull Request Status Board Dec 19, 2019
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Merge:Express and removed Awaiting reviewer feedback labels Dec 19, 2019
@typescript-bot
Copy link
Contributor

A definition owner has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@DanielRosenwasser DanielRosenwasser merged commit 86dc1d9 into DefinitelyTyped:master Dec 20, 2019
Pull Request Status Board automation moved this from Check and Merge to Done Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants